Upgrade Nuget packages & Update lock files #3906
Conversation
|
🥷 Code experts: no user but you matched threshold 10 Jack251970 has most 👩💻 activity in the files. See details
Activity based on git-commit:
Knowledge based on git-blame:
Activity based on git-commit:
Knowledge based on git-blame:
Activity based on git-commit:
Knowledge based on git-blame:
Activity based on git-commit:
Knowledge based on git-blame:
Activity based on git-commit:
Knowledge based on git-blame:
Activity based on git-commit:
Knowledge based on git-blame:
Activity based on git-commit:
Knowledge based on git-blame:
Activity based on git-commit:
Knowledge based on git-blame:
Activity based on git-commit:
Knowledge based on git-blame:
Activity based on git-commit:
Knowledge based on git-blame:
Activity based on git-commit:
Knowledge based on git-blame:
Activity based on git-commit:
Knowledge based on git-blame:
Activity based on git-commit:
Knowledge based on git-blame: ✨ Comment |
|
Be a legend 🏆 by adding a before and after screenshot of the changes you made, especially if they are around UI/UX. |
📝 WalkthroughWalkthroughProject-wide NuGet updates across core, infrastructure, main app, plugins, and tests. Bumps include Microsoft.Extensions 9.0.8, NLog 6.0.3, SharpVectors.Wpf 1.8.5, System.Drawing.Common 9.0.8, JetBrains.Annotations 2025.2.0, FSharp.Core 9.0.303, VirtualizingWrapPanel 2.3.1, NUnit 4.4.0, and plugin-specific packages. Lockfiles refreshed. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (5)
Flow.Launcher.Plugin/Flow.Launcher.Plugin.csproj (1)
70-77: JetBrains.Annotations 2025.2.0: OK. Consider removing explicit SourceLink package on .NET 9.
- JetBrains.Annotations bump is fine.
- On SDK 8+ SourceLink is included by default. Keeping Microsoft.SourceLink.GitHub is redundant unless you’re overriding defaults.
Apply to simplify:
<PackageReference Include="Fody" Version="6.9.2"> <PrivateAssets>all</PrivateAssets> <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets> </PackageReference> - <PackageReference Include="Microsoft.SourceLink.GitHub" Version="8.0.0" PrivateAssets="All" /> <PackageReference Include="JetBrains.Annotations" Version="2025.2.0" />Plugins/Flow.Launcher.Plugin.BrowserBookmark/Flow.Launcher.Plugin.BrowserBookmark.csproj (1)
100-106: Svg.Skia and SkiaSharp version consistency verified
- Only one reference to Svg.Skia 3.0.5 and SkiaSharp 3.119.0 exists in this plugin; no mismatches detected across the repo.
- Flow.Launcher.Localization 0.0.5 remains unchanged and unaffected.
- If bundle size is a concern, consider mirroring the runtime‐cleanup targets used in sibling plugins:
<Target Name="RemoveUnnecessaryRuntimesAfterBuild" AfterTargets="Build"> <RemoveDir Directories="$(OutputPath)runtimes\browser-wasm;$(OutputPath)runtimes\linux-*;$(OutputPath)runtimes\maccatalyst-*;$(OutputPath)runtimes\osx*"/> </Target> <Target Name="RemoveUnnecessaryRuntimesAfterPublish" AfterTargets="Publish"> <RemoveDir Directories="$(PublishDir)runtimes\browser-wasm;$(PublishDir)runtimes\linux-*;$(PublishDir)runtimes\maccatalyst-*;$(PublishDir)runtimes\osx*"/> </Target>Flow.Launcher.Infrastructure/packages.lock.json (1)
81-81: Consider avoiding open-ended version ranges for deterministic buildsThe “requested” constraints are open-ended (e.g., [6.0.3, ), [1.8.5, ), [9.0.8, )). The lockfile pins today, but future restores without locked mode can drift to newer 9.x and cause surprise CI differences.
- Prefer exact versions or central package management (Directory.Packages.props) to pin ranges.
- Enforce restore with locked mode in CI to keep reproducibility.
I can help generate a follow-up PR to centralize and pin if desired.
Also applies to: 87-87, 105-105, 111-111, 193-193
Flow.Launcher.Core/packages.lock.json (1)
262-266: Pin project-level dependency ranges to prevent future driftThe project dependency constraints are open-ended (e.g., [6.0.3, ), [1.8.5, ), [9.0.8, ), JetBrains.Annotations [2025.2.0, )). To avoid unintentional upgrades in a future restore:
- Pin exact versions via Directory.Packages.props or set floating ranges to a bounded minor window if needed.
- Ensure CI uses dotnet restore --locked-mode.
Happy to assist if you want this tightened in the same PR or a follow-up.
Also applies to: 272-272
Flow.Launcher/packages.lock.json (1)
74-76: Ensure restore drift is prevented: centralize versions and enforce locked restores
- No Directory.Packages.props found in the repo – consider adding one for central package version management.
- All critical PackageReference entries are already pinned exactly (e.g., Microsoft.Extensions.* 9.0.8, NLog 6.0.3, SharpVectors.Wpf 1.8.5, JetBrains.Annotations 2025.2.0).
- No GitHub Actions workflows detected under .github/workflows – please verify your CI pipeline invokes
dotnet restore --locked-mode(or the equivalent flag in your CI) so the lockfile ranges ([9.0.8, ), etc.) cannot float to newer versions.Recommendations:
- Introduce Directory.Packages.props or pin exact versions in each csproj.
- Update your CI build definition to always pass
--locked-modetodotnet restore.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (13)
Flow.Launcher.Core/Flow.Launcher.Core.csproj(1 hunks)Flow.Launcher.Core/packages.lock.json(6 hunks)Flow.Launcher.Infrastructure/Flow.Launcher.Infrastructure.csproj(1 hunks)Flow.Launcher.Infrastructure/packages.lock.json(5 hunks)Flow.Launcher.Plugin/Flow.Launcher.Plugin.csproj(1 hunks)Flow.Launcher.Plugin/packages.lock.json(1 hunks)Flow.Launcher.Test/Flow.Launcher.Test.csproj(1 hunks)Flow.Launcher/Flow.Launcher.csproj(2 hunks)Flow.Launcher/packages.lock.json(11 hunks)Plugins/Flow.Launcher.Plugin.BrowserBookmark/Flow.Launcher.Plugin.BrowserBookmark.csproj(1 hunks)Plugins/Flow.Launcher.Plugin.Calculator/Flow.Launcher.Plugin.Calculator.csproj(1 hunks)Plugins/Flow.Launcher.Plugin.Explorer/Flow.Launcher.Plugin.Explorer.csproj(1 hunks)Plugins/Flow.Launcher.Plugin.Program/Flow.Launcher.Plugin.Program.csproj(1 hunks)
🧰 Additional context used
🧠 Learnings (2)
📚 Learning: 2024-10-08T15:52:58.573Z
Learnt from: taooceros
PR: Flow-Launcher/Flow.Launcher#2616
File: Flow.Launcher/Flow.Launcher.csproj:7-7
Timestamp: 2024-10-08T15:52:58.573Z
Learning: In the Flow Launcher project, the version number in the `Flow.Launcher.csproj` file is dynamically updated during the CI/CD process.
Applied to files:
Plugins/Flow.Launcher.Plugin.Explorer/Flow.Launcher.Plugin.Explorer.csprojPlugins/Flow.Launcher.Plugin.Program/Flow.Launcher.Plugin.Program.csprojFlow.Launcher.Plugin/Flow.Launcher.Plugin.csprojFlow.Launcher.Core/Flow.Launcher.Core.csprojFlow.Launcher.Test/Flow.Launcher.Test.csprojFlow.Launcher.Plugin/packages.lock.jsonFlow.Launcher.Infrastructure/Flow.Launcher.Infrastructure.csprojPlugins/Flow.Launcher.Plugin.BrowserBookmark/Flow.Launcher.Plugin.BrowserBookmark.csprojFlow.Launcher.Infrastructure/packages.lock.jsonPlugins/Flow.Launcher.Plugin.Calculator/Flow.Launcher.Plugin.Calculator.csprojFlow.Launcher/Flow.Launcher.csprojFlow.Launcher/packages.lock.jsonFlow.Launcher.Core/packages.lock.json
📚 Learning: 2024-10-08T15:52:58.573Z
Learnt from: taooceros
PR: Flow-Launcher/Flow.Launcher#2442
File: Flow.Launcher.Plugin/Flow.Launcher.Plugin.csproj:4-4
Timestamp: 2024-10-08T15:52:58.573Z
Learning: In .NET 8, SourceLink is included by default, eliminating the need for the `Microsoft.SourceLink.GitHub` package.
Applied to files:
Flow.Launcher.Plugin/Flow.Launcher.Plugin.csproj
🪛 GitHub Check: Check Spelling
Flow.Launcher.Core/packages.lock.json
[warning] 210-210:
NLog is not a recognized word. (unrecognized-spelling)
[warning] 205-205:
NLog is not a recognized word. (unrecognized-spelling)
[warning] 263-263:
NLog is not a recognized word. (unrecognized-spelling)
[warning] 262-262:
NLog is not a recognized word. (unrecognized-spelling)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: gitStream workflow automation
- GitHub Check: gitStream.cm
- GitHub Check: build
🔇 Additional comments (11)
Flow.Launcher.Core/Flow.Launcher.Core.csproj (1)
56-64: Lock file consistency confirmed for FSharp.Core 9.0.303Flow.Launcher.Core/packages.lock.json shows
• type: Direct
• requested: “[9.0.303, )”
• resolved: “9.0.303”No further action needed.
Plugins/Flow.Launcher.Plugin.Explorer/Flow.Launcher.Plugin.Explorer.csproj (1)
48-54: Localization and OleDb upgrades approved
- Verified that Flow.Launcher.Localization has been updated to 0.0.5 everywhere—no remaining 0.0.4 references.
- System.Data.OleDb bumped to 9.0.8 is fine on Windows; ensure target machines have the required OLE DB provider installed.
Flow.Launcher.Test/Flow.Launcher.Test.csproj (1)
50-58: NUnit 4.4.0 + Adapter 5.1.0 compatibility verified
No obsolete NUnit 3 attributes ([RequiresSTA],[RequiresMTA],[Apartment]) were found in the test code. The upgrade is approved—just keep an eye on CI/test discovery for any defaults that might have shifted.Flow.Launcher.Infrastructure/Flow.Launcher.Infrastructure.csproj (1)
71-77: All key package versions are consistent across projects
- NLog is pinned to 6.0.3 in both Flow.Launcher.Infrastructure and Flow.Launcher.Plugin.Program.
- NLog.OutputDebugString (6.0.3), SharpVectors.Wpf (1.8.5), and System.Drawing.Common (9.0.8) are only referenced in the Infrastructure project, as expected.
No version mismatches or duplicate bindings detected.
Plugins/Flow.Launcher.Plugin.Calculator/Flow.Launcher.Plugin.Calculator.csproj (1)
65-65: Localization bump to 0.0.5 verified for Calculator plugin
Resources referenced in Plugins/Flow.Launcher.Plugin.Calculator:
- Views/CalculatorSettings.xaml (lines 30 & 50)
• DynamicResource flowlauncher_plugin_calculator_output_decimal_separator
• DynamicResource flowlauncher_plugin_calculator_max_decimal_placesNo x:Uid attributes detected. Please smoke-test the Calculator settings UI and confirm both labels resolve correctly at runtime.
Plugins/Flow.Launcher.Plugin.Program/Flow.Launcher.Plugin.Program.csproj (1)
67-73: Confirm NLog major-version upgrade and compatibilityThe PR now bumps NLog from 4.x to 6.0.3 across the solution. Before merging, please confirm:
- Intent to upgrade NLog to 6.0.3 in all projects:
• Flow.Launcher.Infrastructure (Flow.Launcher.Infrastructure.csproj)
• Flow.Launcher.Plugin.Program (Flow.Launcher.Plugin.Program.csproj)- Code references that must be tested for breaking changes:
• Flow.Launcher.Infrastructure/Logger/Log.cs (uses NLog.Config, NLog.Targets, NLog.Targets.Wrappers)
• Flow.Launcher/Helper/ErrorReporting.cs
• Plugins/Flow.Launcher.Plugin.Program/Logger/ProgramLogger.cs- No
<nlog>configuration blocks found in any.configfiles—if you rely on runtime config, ensure defaults or embedded settings still apply correctly in Flow.Launcher.- Validate in the Flow.Launcher host that logging behavior, formatting and targets haven’t regressed.
Minor: Microsoft.Extensions.Caching.Memory is already aligned to 9.0.8.
Flow.Launcher.Plugin/packages.lock.json (1)
13-15: JetBrains.Annotations resolved to 2025.2.0; lock entry is consistentThe requested/resolved versions and contentHash update are consistent for net9.0-windows7.0. No further action needed.
Flow.Launcher/Flow.Launcher.csproj (1)
140-152: Microsoft.Extensions. Versions Verified*All Microsoft.Extensions.* package references are consistently updated to version 9.0.8 across the solution:
- Flow.Launcher/Flow.Launcher.csproj
- Microsoft.Extensions.DependencyInjection 9.0.8
- Microsoft.Extensions.Hosting 9.0.8
- Plugins/Flow.Launcher.Plugin.Program/Flow.Launcher.Plugin.Program.csproj
- Microsoft.Extensions.Caching.Memory 9.0.8
No further action required.
Flow.Launcher.Infrastructure/packages.lock.json (1)
81-83: Lockfile bumps are consistent and look good
- NLog stack to 6.0.3
- SharpVectors.Wpf to 1.8.5
- System.Drawing.Common/Microsoft.Win32.SystemEvents to 9.0.8
- JetBrains.Annotations to 2025.2.0 (project and transitive)
These align with the PR intent and keep the ecosystem versions coherent. No red flags.
Also applies to: 87-93, 105-107, 111-116, 126-128, 159-161, 193-193
Flow.Launcher.Core/packages.lock.json (1)
16-18: Core lockfile updates are coherent across projects
- FSharp.Core to 9.0.303
- JetBrains.Annotations to 2025.2.0
- NLog + OutputDebugString to 6.0.3
- SharpVectors.Wpf to 1.8.5
- System.Drawing.Common/Microsoft.Win32.SystemEvents to 9.0.8
- Project dependency blocks mirror these versions
Matches the infrastructure and root lockfiles; no compatibility concerns expected for these minor bumps.
Also applies to: 93-95, 164-166, 202-204, 207-212, 215-217, 225-229, 262-266, 272-272
Flow.Launcher/packages.lock.json (1)
74-109: Broad upgrades to Microsoft.Extensions 9.0.8 and related packages are consistentThe DI/Hosting/Logging stack and their abstractions/providers are uniformly at 9.0.8. Ancillaries (VirtualizingWrapPanel 2.3.1, FSharp.Core 9.0.303, NLog 6.0.3, SharpVectors.Wpf 1.8.5, System.Drawing.Common and EventLog 9.0.8, JetBrains.Annotations 2025.2.0) are aligned across root, Core, and Infrastructure lockfiles. This reduces assembly binding mismatches across projects. LGTM.
Also applies to: 157-159, 199-201, 214-216, 255-263, 265-271, 273-279, 281-288, 290-297, 299-309, 311-320, 322-331, 333-336, 338-346, 348-355, 356-363, 365-373, 375-378, 380-390, 392-400, 402-408, 410-423, 425-435, 437-445, 447-457, 459-469, 471-478, 480-490, 492-495, 555-557, 593-603, 610-613, 675-677, 679-685, 841-849, 862-866, 872-873
Upgrade Nuget packages & Update lock files
Test
All updates are minor version updates, and there is almost no difference in memory usage during testing.
Memory usage:
665mb -> 667mb
Installer size:
101mb -> 98mb